Repository navigation
mapAsync on destroyed device - #4713
Merged
Merged
Conversation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
kainino0x
approved these changes
Oct 21, 2026
kainino0x
enabled auto-merge (squash)
October 21, 2026 22:18
toji
pushed a commit
to gpuweb/gpuweb
that referenced
this pull request
Oct 21, 2026
Per gpuweb/cts#4708 current wording of spec is wrong. This intention of #5114 was to raise AbortError (`deviceLost=true`) when device is invalid (lost) and raise OperationError on invalid buffer. Device check happens before buffer validity check. This matches what dawn does: https://github.com/google/dawn/blob/723d1f04c9d4bae31e67ca7a33589aeb0849efab/src/dawn/native/Buffer.cpp#L815-L817 I discovered the problem while working on wgpu (which powers Servo and Firefox), which currently does buffer validity then device validity check but maps both to OperationError. Added CTS tests: gpuweb/cts#4713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test mapAsync on destroyed device. One variant also checks that for invalid buffer on invalid device invalid device check comes first. Initially I tried to put tests in https://github.com/gpuweb/cts/blob/main/src/webgpu/api/validation/state/device_lost/destroy.spec.ts but we cannot use it's helpers because of async and we benefit from helper we have here.
Dawn passes the tests, Firefox and Servo do not.
Live preview: https://sagudev.github.io/cts/standalone/?debug=1&q=webgpu:api,validation,buffer,mapping:mapAsync,destroyedDevice:*
Spec: gpuweb/gpuweb#10971
Issue: #4708
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.